[GitHub] [spark] thejdeep commented on pull request #35969: [SPARK-38651][SQL] Add configuration to support writing out empty schemas in supported filebased datasources

2022-12-02 Thread GitBox
thejdeep commented on PR #35969: URL: https://github.com/apache/spark/pull/35969#issuecomment-1335353159 @cloud-fan Any further changes that you suggest need to be done ? Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] thejdeep commented on pull request #35969: [SPARK-38651][SQL] Add configuration to support writing out empty schemas in supported filebased datasources

2022-11-01 Thread GitBox
thejdeep commented on PR #35969: URL: https://github.com/apache/spark/pull/35969#issuecomment-1298735509 @cloud-fan We have had users writing data with empty schemas in production and changing the schema of a non-trivial number of rows seems like a big change. Spark allows creating empty

[GitHub] [spark] thejdeep commented on pull request #35969: [SPARK-38651][SQL] Add configuration to support writing out empty schemas in supported filebased datasources

2022-04-27 Thread GitBox
thejdeep commented on PR #35969: URL: https://github.com/apache/spark/pull/35969#issuecomment-238237 @xkrogen @robreeves Thanks for your feedback, addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] thejdeep commented on pull request #35969: [SPARK-38651][SQL] Add configuration to support writing out empty schemas in supported filebased datasources

2022-04-27 Thread GitBox
thejdeep commented on PR #35969: URL: https://github.com/apache/spark/pull/35969#issuecomment-236126 @dongjoon-hyun @cloud-fan Can you please take a look at this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] thejdeep commented on pull request #35969: [SPARK-38651][SQL] Add configuration to support writing out empty schemas in supported filebased datasources

2022-03-24 Thread GitBox
thejdeep commented on pull request #35969: URL: https://github.com/apache/spark/pull/35969#issuecomment-1078653282 cc: @cloud-fan @mridulm @gatorsmile Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL