[GitHub] [spark] ulysses-you commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2023-03-01 Thread via GitHub
ulysses-you commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1451157095 @viirya sure, I have updated the pr description and jira. Hope it is more clear now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] ulysses-you commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-11-01 Thread GitBox
ulysses-you commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1299431744 @gengliangwang it is a bug fix and also have improvement for saving unnecessary cast. The query will produce the unexpected precision and scale. before: `decimal(28,2)`, after:

[GitHub] [spark] ulysses-you commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-05-31 Thread GitBox
ulysses-you commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1143024193 thank you @cloud-fan address all comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] ulysses-you commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-05-30 Thread GitBox
ulysses-you commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1140926253 > Besides the bug fix test in union.sql, we'd better test all the DecimalArithmetic types. I don't think they've been covered before. @manuzhang yeah, will add some more

[GitHub] [spark] ulysses-you commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-05-29 Thread GitBox
ulysses-you commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1140589408 cc @cloud-fan @viirya @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to