[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-729342315 Thanks @HyukjinKwon! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-729074737 Thanks @dongjoon-hyun @maropu @cloud-fan This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727534418 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727364039 @dongjoon-hyun Thanks! I will update this tonight or tomorrow. This is an automated message from the Apache Git

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727325324 Thanks @dongjoon-hyun. Let's wait for @cloud-fan's comment for https://github.com/apache/spark/pull/30341#discussion_r522822589 after this weekend.

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727255265 > It would be great if we can have a benchmark suite (from the code in the PR description), @viirya . Yes, @dongjoon-hyun, I remember it. :) I will add a benchmark suite

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727242745 Thanks @maropu This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727164174 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727155028 Hmm, actually for https://github.com/apache/spark/pull/30341#discussion_r522904967, that is to add some tests in `SQLQueryTestSuite` with `--CONFIG_DIM

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-727154709 I addressed most of comments except for https://github.com/apache/spark/pull/30341#discussion_r522822589 and https://github.com/apache/spark/pull/30341#discussion_r522904967.

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-726217652 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] viirya commented on pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

viirya commented on pull request #30341: URL: https://github.com/apache/spark/pull/30341#issuecomment-725837444 cc @cloud-fan @dongjoon-hyun @maropu @HyukjinKwon This is an automated message from the Apache Git Service. To