[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872619510 Thanks @aokolnychyi for this work and all for the review! Merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872619166 In GA, all tests are passed. Only "Hadoop 2 build with SBT" failed which seems unrelated: ``` [error]

[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872472840 Thank you, @cloud-fan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872405669 also cc @gengliangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872403558 Thanks @aokolnychyi! I am not sure if we still can merge this in after branch cut? If not, maybe we can have this in first, if there is no major comments/concerns, and

[GitHub] [spark] viirya commented on pull request #32921: [SPARK-35779][SQL] Dynamic filtering for Data Source V2

2021-07-01 Thread GitBox
viirya commented on pull request #32921: URL: https://github.com/apache/spark/pull/32921#issuecomment-872002816 > This WIP PR has a working prototype for SPARK-35779 per design doc. This is not WIP PR anymore. @aokolnychyi Could you update the description? Thanks. -- This is an