[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-12 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r895210608 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-12 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r895210329 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-12 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r895208448 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-12 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r895206894 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-10 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r894700485 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-10 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r894697512 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-10 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r894695373 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,29 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-09 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r893926925 ## python/pyspark/sql/tests/test_arrow.py: ## @@ -495,6 +509,22 @@ def test_schema_conversion_roundtrip(self): schema_rt =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-08 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r892890115 ## python/pyspark/sql/tests/test_arrow.py: ## @@ -495,6 +509,22 @@ def test_schema_conversion_roundtrip(self): schema_rt =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-08 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r892863327 ## python/pyspark/sql/tests/test_session.py: ## @@ -379,6 +381,54 @@ def test_use_custom_class_for_extensions(self): ) +class

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-07 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r891581163 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,30 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36793: [SPARK-39406][PYTHON] Accept NumPy array in createDataFrame

2022-06-07 Thread GitBox
xinrong-databricks commented on code in PR #36793: URL: https://github.com/apache/spark/pull/36793#discussion_r891581163 ## python/pyspark/sql/session.py: ## @@ -952,12 +953,30 @@ def createDataFrame( # type: ignore[misc] schema = [x.encode("utf-8") if not