[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-07-02 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-872796115 Sure. Let me do it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-07-02 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-872793590 Great thanks for the help! @viirya @HeartSaVioR I'll update the rest PR and submit the last one of RocksDBStateStoreProvider today. -- This is an automated message

[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-07-01 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-872080944 Thanks again for the help of @HeartSaVioR and @viirya. The test failure is not related to the changes. Let me retrigger. -- This is an automated message from the

[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-07-01 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-872002977 @HeartSaVioR Addressed done, the redundant code should be introduced by my old commits. Thanks for reminding me! -- This is an automated message from the Apache Git

[GitHub] [spark] xuanyuanking commented on pull request #32933: [SPARK-35785][SS] Cleanup support for RocksDB instance

2021-06-30 Thread GitBox
xuanyuanking commented on pull request #32933: URL: https://github.com/apache/spark/pull/32933#issuecomment-871436858 Rebased and addressed all the comments. Thanks for your heads-up! cc @viirya @HeartSaVioR -- This is an automated message from the Apache Git Service. To respond to the