subject:"\[GitHub\] \[spark\] zhengruifeng commented on a diff in pull request #43010\: \[SPARK\-41086\]\[SQL\] Use DataFrame ID to semantically validate CollectMetrics"

[GitHub] [spark] zhengruifeng commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

2023-09-21 Thread via GitHub

zhengruifeng commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1333829755 ## python/pyspark/sql/connect/plan.py: ## @@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: assert self._child is

[GitHub] [spark] zhengruifeng commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

2023-09-20 Thread via GitHub

zhengruifeng commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332491666 ## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ## @@ -990,6 +990,9 @@ message CollectMetrics { // (Required) The metric

[GitHub] [spark] zhengruifeng commented on a diff in pull request #43010: [SPARK-41086][SQL] Use DataFrame ID to semantically validate CollectMetrics

2023-09-20 Thread via GitHub

zhengruifeng commented on code in PR #43010: URL: https://github.com/apache/spark/pull/43010#discussion_r1332489254 ## python/pyspark/sql/connect/plan.py: ## @@ -1197,6 +1197,7 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: