CarolinePeng commented on a change in pull request #23280: [MINOR][SQL] Some
errors in the notes.
URL: https://github.com/apache/spark/pull/23280#discussion_r240480174
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##########
@@ -101,7 +101,7 @@ package object expressions {
StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable,
a.metadata)))
}
- // It's possible that `attrs` is a linked list, which can lead to bad
O(n^2) loops when
Review comment:
The cost time to access the linked list using ordinal is O (n), but I do not
combine BindReferences to analyze the cost time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
