Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Yes, I think so. Based on the current MetricsSystem, it is hard to avoid
`MetricsRegistry`, whether explicitly or implicitly (unless we
refactor/abstract this part a lot). Also true if user want
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/11994
I see, I didn't recognize that the same registry is used to for source as
well.
in this case, even we have some way to eliminate MetricsRegistry from the
API signature, haven't we still
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Hi @CodingCat , thanks a lot for your explanation. IIUC, from the code you
mentioned above, we still need to pass `MetricRegistry` to `Reporter`,
otherwise how would a reporter report the
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/11994
@jerryshao I mean we also need to provide BaseReporter trait
```scala
trait Sink {
protected val reporter: BaseReporter = createReporter()
def createReporter():
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@CodingCat , IIUC the way you mentioned will also expose Codahale
`Reporter` to user, can you please explain more? Thanks!
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Sorry for late response, I was off last two weeks. Currently I don't have a
better solution for this, @CodingCat let me think about your suggestion, thanks
a lot :).
---
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/11994
if I understand correctly, the only issue here is that we exposed
codehale's MetricsRegistry in Sink base
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/11994
What's our thought on this, @jerryshao ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84250/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84250/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84250/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@rxin , thanks for your comment. The key motivation of this PR is to expose
the metrics Sink/Source interface for third-party plugins, so that we don't
need to maintain every different
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/11994
Hey so my main question is whether we should expose the coda hale metric
library directly. In the past, we have done this and it has come back to bite
us. For example, exposing the Hadoop
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84209/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84209/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84209 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84209/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84202/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84202/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84201/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84201 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84201/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84202/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84201/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@felixcheung thanks for your reviewing. I think there's no next step,
current changes should be enough for user to externalize customized metrics
source and sink.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/11994
what's the next step on this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83778/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #83778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83778/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #83778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83778/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83772/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #83772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83772/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #83772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83772/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Sure, let me update the code.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
@jerryshao Could you please rebase this PR then we can start review it?
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
@jerryshao Since this is to add a set of public API, should we start a SPIP
to push it forward?
As for the changes in this PR, they look good overall to me personally, but
still I think it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #79394 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79394/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79394/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #79394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79394/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79223/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #79223 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79223/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #79223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79223/testReport)**
for PR 11994 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78672/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78672 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78672/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78672 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78672/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78605/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78605 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78605/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78605 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78605/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78595/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78595/testReport)**
for PR 11994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78595/testReport)**
for PR 11994 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78594/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78594/testReport)**
for PR 11994 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #78594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78594/testReport)**
for PR 11994 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
Great! Let me add this to my Q3 TODO list, and inform you when we are ready
to push this forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@jiangxb1987 yes, I can work this if you could help to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
Are you still working on this? @jerryshao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
72 matches
Mail list logo
