Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13493
Merging with master
Thanks all!
@zjffdu Did you want to backport this to branch-2.3 too?
---
-
To unsubscribe,
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/13493
LGTM!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90147/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #90147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90147/testReport)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #90147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90147/testReport)**
for PR 13493 at commit
Github user ludatabricks commented on the issue:
https://github.com/apache/spark/pull/13493
LGTM retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
Thanks @jkbradley The failed tests seems unrelated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #4167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4167/testReport)**
for PR 13493 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13493
LGTM pending fresh tests
Sorry for the delay!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #4167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4167/testReport)**
for PR 13493 at commit
Github user ludatabricks commented on the issue:
https://github.com/apache/spark/pull/13493
The bug is confirmed. The fix looks pretty reasonable to me. ping
@jkbradley .
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82330/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82330/testReport)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82330/testReport)**
for PR 13493 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13493
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82319/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82319/testReport)**
for PR 13493 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82315/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82315/testReport)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82319/testReport)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #82315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82315/testReport)**
for PR 13493 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/13493
ping @zjffdu Looks reasonable fix, But pls resolve the conflicts! Thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81076/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #81076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81076/consoleFull)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #81076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81076/consoleFull)**
for PR 13493 at commit
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
ping @jkbradley @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
PR is updated, @holdenk @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #66589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66589/consoleFull)**
for PR 13493 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66589/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #66589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66589/consoleFull)**
for PR 13493 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13493
@zjffdu Enjoy vacation and no worries - I don't think this is blocking
anything and we can circle back in a week :)
---
If your project is set up for it, you can reply to this email and have your
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
Sorry, I am in vacation. Will update it next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13493
Ping --- let me know if you'd like someone to take it over. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13493
Same here, looks fine except for @holdenk 's comment. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13493
This looks pretty reasonable to me, the only thing is (and its relatively
minor) testing the default param might be better as a tests.py test rather than
as a doc test since the doctests are part
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65071/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #65071 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65071/consoleFull)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #65071 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65071/consoleFull)**
for PR 13493 at commit
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
@mengxr @jkbradley I think we should keep as less logic in python side as
possible. So I didn't update the PR, please help review. Thanks
---
If your project is set up for it, you can reply to
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13493
@jkbradley I will update the PR soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13493
Pinging! Is this still active?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #3236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3236/consoleFull)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #3236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3236/consoleFull)**
for PR 13493 at commit
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/13493
Shall we change the logic in the Python wrapper and set `numPartitions`
correctly if it is `-1`? Please also update the PR description to add more
details to the changes.
---
If your project is
Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/13493
lgtm cc: @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59923/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #59923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59923/consoleFull)**
for PR 13493 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13493
**[Test build #59923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59923/consoleFull)**
for PR 13493 at commit
56 matches
Mail list logo
