Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/14035
Sorry I'm seeing this so late, but thank you all for the PR & reviews!
@jaceklaskowski Regarding the explicit partitioning in unit tests, that's
historical: In the past, we had run into
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Thank you for reviewing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14035
LGTM, merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65883/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65883/consoleFull)**
for PR 14035 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65881/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65881 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65881/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65883/consoleFull)**
for PR 14035 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Thanks @yanboliang and @jaceklaskowski . I addressed comments except for
few comments I am not too sure of and I think are not related changes.
---
If your project is set up for it, you can
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65881/consoleFull)**
for PR 14035 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14035
@HyukjinKwon I have made a pass and this PR look good overall. Could you
double check whether all ML test cases are covered? Since I found we used
implicit import of different style at
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Thank you!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14035
Sorry for late response. I like this change and will have a look soon.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Hi @mengxr, @yanboliang and @jkbradley, if these changes are so big, I can
just leave `testImplicits` and let others fix them later without sweeping.
Could you please take a look?
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65758/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65758/consoleFull)**
for PR 14035 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65757/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65757/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65758/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #65757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65757/consoleFull)**
for PR 14035 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64632/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #64632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64632/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #64632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64632/consoleFull)**
for PR 14035 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Hi @jkbradley, could you take a look for this one please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63487/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #63487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63487/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #63487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63487/consoleFull)**
for PR 14035 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
ping @mengxr and @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
hm.. I can close if it looks inappropriate or it seems making a lot of
conflicts across PRs. Could you give some feedback please @mengxr and
@yanboliang ?
---
If your project is set up for
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
ping @mengxr and @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Gentle ping @mengxr and @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
Hi @mengxr, is this the change you meant? Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
@mengxr, @yanboliang, Could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61681/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #61681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61681/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #61681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61681/consoleFull)**
for PR 14035 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61679/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #61679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61679/consoleFull)**
for PR 14035 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #61679 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61679/consoleFull)**
for PR 14035 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14035
cc @mengxr, @yanboliang and @jaceklaskowski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
48 matches
Mail list logo
