Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14118
@HyukjinKwon hi. The explanation above intends to help reviewers better
understand how we introduced the regression. Regarding whether `StringType`
should be ignored or not, I don't have strong
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14118
I just wonder why string should be ignored in the case above. I mean, you
just said "we don't need to handle type-specific null values" and it seems
strings are okay to handle together.
---
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14118
FYI, before
[SPARK-14143](https://issues.apache.org/jira/browse/SPARK-14143), null values
had been handled this way: :
```scala
if (datum == options.nullValue && nullable &&
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/14118
The diff that github shows is a mess. The actual diff (which is quite
small) is:
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14118
No - I just noticed a JIRA that said it was a regression, so I wanted to
make sure you caught this in the RC cycle
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14118
@shivaram did you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14118
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62025/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14118
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14118
**[Test build #62025 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62025/consoleFull)**
for PR 14118 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14118
Actually, https://github.com/apache/spark/pull/12921 includes duplicated
changes with here. I will close mine since I like this one more than mine but
it would be great if it has
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14118
**[Test build #62025 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62025/consoleFull)**
for PR 14118 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14118
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
12 matches
Mail list logo
