Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14182
LGTM! merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63858/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63858/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63858/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63826/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63826/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63824/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63824/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63826/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63824/consoleFull)**
for PR 14182 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14182
This looks fine to me - @felixcheung feel free to merge this when you think
its good to go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63795/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63795/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63795/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63764/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63764/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63764/consoleFull)**
for PR 14182 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14182
Please see comment
https://github.com/apache/spark/pull/14182#discussion_r73985582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14182
Minor comments and please check this earlier
[one](https://github.com/apache/spark/pull/14182#discussion_r73985582), looking
good.
@shivaram @mengxr any comment? also any thought of the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63663/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63663 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63663/consoleFull)**
for PR 14182 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14182
I haven't had a chance to look at the PR, but the function name
`isoreg`seems in line with
https://stat.ethz.ch/R-manual/R-devel/library/stats/html/isoreg.html -- So I'd
say `spark.isoreg` sounds
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63663 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63663/consoleFull)**
for PR 14182 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@felixcheung I addressed your comments. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63453/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63453 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63453/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63453/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63452/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63452/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63452/consoleFull)**
for PR 14182 at commit
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14182
LGTM. Thanks @wangmiao1981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
ping @junyangq
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63085/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63085 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63085/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63085 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63085/consoleFull)**
for PR 14182 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@junyangq I added the weightCol. Can you take a look?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14182
Sounds good. Thank you @wangmiao1981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@junyangq Yanbo has pointed me an example of adding weightcol. I will
update this PR tomorrow.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63055/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63055 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63055/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63054/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63054/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63055 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63055/consoleFull)**
for PR 14182 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@junyangq I add a check in the wrapper to make sure that the right hand
size is 1 and add a unit test.
For the optional weight, can you give me some explanation or function
signature?
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63054/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63035/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63035/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #63035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63035/consoleFull)**
for PR 14182 at commit
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14182
@wangmiao1981 not sure if R formula an essential need here, since there is
only one feature variable. If used, perhaps we need a test to verify only one
variable is included on the right hand side
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@felixcheung @yanboliang @junyangq I have addressed all your comments.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62989/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62989/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62989/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62986/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62986/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62986/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62980/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62980/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62978/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62978/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62977/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62977/consoleFull)**
for PR 14182 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62980/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62978/consoleFull)**
for PR 14182 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14182
**[Test build #62977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62977/consoleFull)**
for PR 14182 at commit
82 matches
Mail list logo
