Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14561
If there's no long-term goal for these changes we should close this PR. By
itself I don't see it making things any less complicated.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14561
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14561
@lshmouse did you get the chance to write a document / something explaining
what's the long term goal for this change?
The way it is, I don't see it helping much. There's still a lot of
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14561
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14561
Finally someone took the responsibility and is clearing that important and
critical path in Spark Core. Whenever I see the code, I feel what @lshmouse
felt -- it has to be refactored to
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14561
I'd rather not see a huge refactoring PR, but instead a document that
outlines what would be done and the reasons for it. It's better if the PRs
themselves are small-ish.
---
If your project is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14561
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14561
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/14561
Agreed with @jerryshao. @lshmouse could you submit the whole refactoring
PR in order to show why this one is necessary? It's better to not refactor
stable code paths unless there is a strong
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14561
**[Test build #63643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63643/consoleFull)**
for PR 14561 at commit
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/14561
@jerryshao
The patch doesn't just change the code structure. It distinguish the
responsibility of these two classes.
What's more, it's the first step to refactor the schedule path, because
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/14561
Do you have any specific reason or use case that have to refactor this part?
IMHO, I think unless we have a concrete reason to change it, it is better
not to do refactoring on this
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/14561
@zsxwing @srowen
Could you please help to review this patch? Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/14561
@srowen Please help to trigger the Jenkins test, Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/14561
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user lshmouse commented on the issue:
https://github.com/apache/spark/pull/14561
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14561
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63435/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14561
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14561
**[Test build #63435 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63435/consoleFull)**
for PR 14561 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14561
**[Test build #63435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63435/consoleFull)**
for PR 14561 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14561
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14561
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
22 matches
Mail list logo
