[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14641 Thanks - Merging this to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14641 I think tests are only passing string, but we should coerce this to be safe. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-15 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14641 Thanks @yanboliang - Do you know how the existing tests were passing ? Should we add a new test case for this ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-14 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14641 cc @felixcheung @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14641 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14641 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63772/ Test PASSed. ---

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14641 **[Test build #63772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63772/consoleFull)** for PR 14641 at commit

[GitHub] spark issue #14641: [Minor] [SparkR] spark.glm weightCol should in the signa...

2016-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14641 **[Test build #63772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63772/consoleFull)** for PR 14641 at commit