[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14924 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14924 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14924 LGTM. Seems like this should go into 2.0.x as well since it's really a bug fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64856/ Test PASSed. ---

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64856/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64856/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/14924 @srowen yes in stringExpressions the trim is on with UTF8String. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14924 The implementation in `stringExpressions.scala` generates code that calls `trim()`, so just double-checking, that's calling UTF8String not String right? Then yeah LGTM --- If your project is set

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64827/ Test PASSed. ---

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64827/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64827/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/14924 @rxin Done 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14924 Can you add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64798/consoleFull)** for PR 14924 at commit

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64798/ Test FAILed. ---

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64798/consoleFull)** for PR 14924 at commit