Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
@yhuai ack OK I'll fix that. I must have managed to miss something in the
deps file when I resolved conflicts on the cherry pick. It can't be complex to
touch up though.
---
If your project is set
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14958
```
Using `mvn` from path:
/home/jenkins/workspace/spark-branch-1.6-lint/build/apache-maven-3.3.9/bin/mvn
Spark's published dependencies DO NOT MATCH the manifest file
(dev/spark-deps).
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
Merged to master/2.0/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65001/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #65001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65001/consoleFull)**
for PR 14958 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #65001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65001/consoleFull)**
for PR 14958 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65000/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #65000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65000/consoleFull)**
for PR 14958 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #65000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65000/consoleFull)**
for PR 14958 at commit
Github user a-roberts commented on the issue:
https://github.com/apache/spark/pull/14958
Straight up rewrite so it's just testing that the Snappy version we include
happens to have the magic header handling in, kept it simple
---
If your project is set up for it, you can reply to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
Yeah I'm cool to merge this now, but if you have a test, OK. Is it testing
Spark or just testing Snappy though?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user a-roberts commented on the issue:
https://github.com/apache/spark/pull/14958
I'm almost done with adding in the test case anyway, involved a quick
rewrite to use Scala code, had fun rewriting the for loop for the test into a
while, I _think_ it would manifest itself if
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/14958
@srowen The bug does manifest in Spark. I've been running this upgrade in
production for a few weeks with no issues. This should be merged IMO.
---
If your project is set up for it, you can
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14958
Fair enough. It was just an idea that would make the upgrade even more
super-needed. The issues that snappy has fixed could manifest in various ways
in Spark and while doing so could uncover
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
I don't know that the bug that was fixed has manifested yet in Spark;
certainly not in the unit tests. It seems like something that could affect some
execution out in the wild. It seems reasonable
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64932/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14958
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #64932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64932/consoleFull)**
for PR 14958 at commit
Github user a-roberts commented on the issue:
https://github.com/apache/spark/pull/14958
Good point,
https://github.com/xerial/snappy-java/commit/60cc0c2e1d1a76ae2981d0572a5164fcfdfba5f1
shows the changes that were made, so we would have a checkMagicHeader
equivalent added to the
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14958
Would be nice to have a test in Spark to see if the changes to snappy made
any sense to Spark (not that I'm against -- just as a safety measure that it
did improve things if possible).
---
Github user a-roberts commented on the issue:
https://github.com/apache/spark/pull/14958
Yep, builds in progress on our farm against the latest 1.6 code using
1.1.2.6 so will improve the PR should there be no problems
---
If your project is set up for it, you can reply to this email
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
Looks OK for master/2.0, and even 1.6 as it's already on 1.1.2.1, and
changes from 1.1.2.1 to 1.1.2.4 look like strict fixes/improvements.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14958
**[Test build #64932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64932/consoleFull)**
for PR 14958 at commit
25 matches
Mail list logo
