Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15817
Sorry for delay - this LGTM. Given it's been around for a while and given
RC2 is likely to be cut, I've gone ahead and merged to master / branch-2.1.
Thanks!
---
If your project is set up for it,
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15817
LGTM given our planned follow up to update the documentation for both
Python and Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15817
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15817
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69331/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15817
**[Test build #69331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69331/consoleFull)**
for PR 15817 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15817
**[Test build #69331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69331/consoleFull)**
for PR 15817 at commit
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15817
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15817
ok let's re-ping @MLnick / @sethah - I know we asked to update the
docstring - but the current one is consistent with the Scala docstring so maybe
it make sense as is (otherwise we should probably
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15817
Thanks for working on this @techaddict - one super minor point , but could
you also maybe update the PR description to mention the testing is done with
new doctests? This is really minor but for
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15817
ping @davies @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15817
**[Test build #68649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68649/consoleFull)**
for PR 15817 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15817
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15817
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68649/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15817
**[Test build #68649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68649/consoleFull)**
for PR 15817 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15817
@jkbradley done ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15817
Can you please implement the Param directly in Bucketizer and
QuantileDiscretizer? Just like in Scala, HasHandleInvalid has built-in Param
doc which applies to existing use cases but not
16 matches
Mail list logo
