Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15843
Good point @holdenk --- @techaddict could you also please update the PR
title to say "JavaWrapper" instead of "StringIndexer"?
---
If your project is set up for it, you can reply to this email
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15843
ping @davies if you have time for final review/merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15843
LGTM thanks for fixing this @techaddict :D :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15843
@holdenk updated the description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15843
So this change looks good to me, but it seems like it fixes more than just
the bug described in the JIRA & PR description with @jkbradley's change
integrated (namely the issue with param copy which
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68515/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68515/consoleFull)**
for PR 15843 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68516/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68516/consoleFull)**
for PR 15843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68516/consoleFull)**
for PR 15843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68515/consoleFull)**
for PR 15843 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15843
LGTM with minor doc comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68514/consoleFull)**
for PR 15843 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68514/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68513/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68513 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68513/consoleFull)**
for PR 15843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68514 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68514/consoleFull)**
for PR 15843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15843
**[Test build #68513 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68513/consoleFull)**
for PR 15843 at commit
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15843
@jkbradley looks good, merged ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15843
You're right! It's another bug: copy should be implemented in JavaParams,
not JavaModel. I'm sending this PR to fix that:
https://github.com/techaddict/spark/pull/1
Can you please
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15843
@jkbradley yes I did it for `JavaWrapper` first, but try running tests with
it gives
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68478/consoleFull
---
If your project is
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15843
Thanks a lot for finding & reporting this! The fix should probably go in
JavaWrapper, not JavaModel, right?
I tested this manually (in JavaWrapper), and it seems to fix the
problematic
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15843
cc: @jkbradley @davies @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
27 matches
Mail list logo
