Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15888
Merged into master, branch-2.1 and branch-2.0. Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15888
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68924/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68924/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68924/consoleFull)**
for PR 15888 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68889/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68889/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68889/consoleFull)**
for PR 15888 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68883/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68883/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68883/consoleFull)**
for PR 15888 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15888
looks good. We don't have this but how about adding tests for
`sparkCheckInstall`? we could at least check for the error cases it has right
now?
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68787/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68787/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68787/consoleFull)**
for PR 15888 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15888
I think what you have here is reasonable but what about checking for
spark.submit.deployMode from the sparkConfig list here too?
I'm all for fixing this ASAP - thinking longer term, I
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15888
@felixcheung What about transferring ```SparkConf``` from JVM to R via
environment when JVM creates R process? I guess it can work but need some time
to verify and test. Since it's critical bug
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15888
That might be a reasonable approach.
In fact, thinking more about this I think it really should instantiate a
sparkConf to read any conf file etc as well (which could set a value for master
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68720/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68720 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68720/consoleFull)**
for PR 15888 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15888
@felixcheung That's OK, and will make the fix more simple. I think
```sparkCheckInstall``` can only handle some conditions by arguments passed in.
However, if we can not judge the deploy mode
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68720 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68720/consoleFull)**
for PR 15888 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15888
We do try to maintain compatibility with sparkR.init()
And we should avoid adding parameter in the middle of the parameter list -
it breaks users depending on parameter order.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68709/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68709/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68709/consoleFull)**
for PR 15888 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15888
cc @junyangq
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15888
cc @felixcheung @shivaram @zjffdu @sun-rui I'm not sure this fix affects
other scenarios, but it can fix my bug.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68659/consoleFull)**
for PR 15888 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68659/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68658/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15888
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68658/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68659/consoleFull)**
for PR 15888 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15888
**[Test build #68658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68658/consoleFull)**
for PR 15888 at commit
42 matches
Mail list logo
