Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16376
Awesome always enthusiastic about fixing minor nits!! I merged this into
master. I didn't merge it into 2.1 but I don't feel strongly about it.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72484/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #72484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72484/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #72484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72484/testReport)**
for PR 16376 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16376
yes, I think this is ready (I just noticed a couple of minor nits with a
fresh read but no real changes)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72477/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #72477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72477/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #72477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72477/testReport)**
for PR 16376 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16376
@squito I just noticed this hasn't been merged. Is this good to go pending
tests passing again?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16376
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71223/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71223 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71223/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71223/testReport)**
for PR 16376 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16376
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71156/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71156/testReport)**
for PR 16376 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16376
LGTM, thanks @squito !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16376
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71141/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71141 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71141/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71156/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71141 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71141/testReport)**
for PR 16376 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71137/testReport)**
for PR 16376 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71137/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71137 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71137/testReport)**
for PR 16376 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71084/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71084/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #71084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71084/testReport)**
for PR 16376 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16376
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70936/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70936/testReport)**
for PR 16376 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70937/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70937/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70937/testReport)**
for PR 16376 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/16376
Thanks for the feedback. I've updated the comment on `myLocalityLevels`.
Also I updated the tests slightly. To ensure that we're really testing no
delay, I updated the tests to use a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70936/testReport)**
for PR 16376 at commit
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/16376
@kayousterhout I see. Thanks for the explanations :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16376
@lirui-intel yes, that's consistent with my understanding. The
TaskSetManager still checks that it's not going beyond the currently-allowed
locality level
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/16376
The change looks good to me, although I still want to make sure I
understand it correctly. Before the change, a locality level is invalid if it
has delay=0. The patch changes that and makes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70495/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70495/testReport)**
for PR 16376 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16376
It'd be nice to check whether the test case attached to SPARK-1937 still
applies. Reading the description of that bug, it seems related not only to this
but to other things you've been playing with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70494/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70494/testReport)**
for PR 16376 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16376
At first glance, this looks like the right change - but I might be missing
something.
Also +CC @lirui-intel who made this change.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70495/testReport)**
for PR 16376 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16376
**[Test build #70494 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70494/testReport)**
for PR 16376 at commit
58 matches
Mail list logo
