Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93594/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #93594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93594/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #93594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93594/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93100/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #93100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93100/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #93100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93100/testReport)**
for PR 16476 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16476
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@HyukjinKwon Done, thanks : )
Ping @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16476
gentle ping @gczsjdy
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@maropu Sure, I will update it this week.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/16476
@gczsjdy Can you resolve the conflict?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@cloud-fan Do you have comment on this version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75038/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #75038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75038/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #75038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75038/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74655/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74655/testReport)**
for PR 16476 at commit
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@cloud-fan I have submitted a new version to support implicit cast.
We determine the implicit cast type in analysis stage, so maybe we won't do
`eval` then, so we can't be 100% intelligent, for
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74655/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74639/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74639/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74639/testReport)**
for PR 16476 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16476
I don't think we should follow Hive for everything even for mistakes. I
think we should not care about which one is more popular, but which one is more
reasonable.
---
If your project is set up
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@viirya I have tested with Hive 2.1.1, `select field(2, '2', 2);` will
return 2 while it will return 1 in MySQL, I also read Hive's code, where I
found it will first compare the data type which is
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16476
@gczsjdy I am not sure where you find the definition of Hive's `field`
function. But in this link:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74009/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74009/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #74009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74009/testReport)**
for PR 16476 at commit
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@cloud-fan I have checked some other popular RDBMS, such as Oracle,
Microsoft SQL Server, PostgreSQL, DB2, SQLite, neither of them support function
`FIELD`.
In my opinion, Hive has an important
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16476
It seems MySQL do need all arguments in `FIELD` have same type(or can be
converted to same type):
http://www.w3resource.com/mysql/string-functions/mysql-field-function.php
I think this
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@gatorsmile Do you think we can merge this PR? Or is there something that
need to modify?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@tejasapatil Got it, thanks for your review. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16476
@gczsjdy : I had one comment in past about `genIfElseStructure` but after
giving more thought, I was not able to think about a better way to do that. I
am fine withthe current version of code
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@tejasapatil Sorry to bother, is there still something need to modify?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@cloud-fan Could you please help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72994/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72994/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72994/testReport)**
for PR 16476 at commit
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@gatorsmile Hi, this patch has passed all tests, is there some code I
still need to modify? Thank you for working on this.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72554/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72554/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72554/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72553/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72553/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72553/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72505/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72505/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72505 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72505/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72489/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72489/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72431/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72431/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72431/testReport)**
for PR 16476 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72427/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72427/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #72427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72427/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71996/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #71996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71996/testReport)**
for PR 16476 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16476
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16476
**[Test build #71996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71996/testReport)**
for PR 16476 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16476
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
ping @rxin @gatorsmile @tejasapatil @viirya
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
Thanks @viirya for the review and sorry for the late reply.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
@chenghao-intel
I think that the optimize rule will fold the parameters that have different
types with param0, and then disorganize the parameters' index. Thanks.
@rxin
I have removed
Github user chenghao-intel commented on the issue:
https://github.com/apache/spark/pull/16476
@gczsjdy can you please add [WIP] in the title, until you feel the code is
ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/16476
cc @chenghao-intel @adrian-wang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
83 matches
Mail list logo
