Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16630
Note the output format of GLR ```summary.toString``` is:
```
Coefficients:
Feature Estimate Std ErrorT Value P Value
features_0 2.21304 0.00279 792.03163 0.0
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16630
LGTM, merged into master. Thanks for all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79970/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79970/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79970/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79766/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79766/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79766/testReport)**
for PR 16630 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
Made a new commit to address the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79688/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79688/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79686/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79686/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79688/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79686/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79685/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79685/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #79685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79685/testReport)**
for PR 16630 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@yanboliang Thanks for the suggestions. I have made a new commit that
addresses your comments.
In the new version, I used an array of tuple to represent the coefficient
matrix. I used
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@yanboliang Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78992/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #78992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78992/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #78992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78992/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73439/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73439/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73439/testReport)**
for PR 16630 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16630
I think this is helpful to have - added a few comments.
Any more feedback @jkbradley @yanboliang @srowen @MLnick?
---
If your project is set up for it, you can reply to this email and have
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@felixcheung Could you take another look at this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@imatiach-msft I'm not sure the R^2s are used much in the GLM context. The
deviance, loglikelihood and AIC/BICs are most often used for ANOVA and model
comparison. The GLM
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73073/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73073/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73073/testReport)**
for PR 16630 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
@actuaryzhang sorry, can you comment on this question I had above:
One question, out of scope of the specific changes in this review: are
there any other summary statistics that we could
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73066/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73066/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73060/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73060/testReport)**
for PR 16630 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
@actuaryzhang thanks, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73066/testReport)**
for PR 16630 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@imatiach-msft @felixcheung
I cleaned up the tests as suggested, and also updated the R GLM wrapper to
use the result from this PR. Please let me know if there is any other
suggestions.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #73060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73060/testReport)**
for PR 16630 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
Thanks for the updates, the changes look good to me. One question, out of
scope of the specific changes in this review: are there any other summary
statistics that we could add in the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72901/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #72901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72901/testReport)**
for PR 16630 at commit
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@felixcheung @imatiach-msft Thanks much for the review. Made most changes
suggested. Please see my inline replies.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #72901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72901/testReport)**
for PR 16630 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
the code looks very good, I added a few minor comments, will take another
look tomorrow, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
@actuaryzhang sorry I'm at Spark Summit East, will take a look soon. For
the feature name or "lazy val featureName: Array[String]", I recall there is a
sparse (eg output by HashingTF) and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
Could somebody help review this PR? I think this will make gathering the
estimation results in Scala much easier. This will also be helpful in
constructing the tests. For example, the GLM
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71998/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71998/testReport)**
for PR 16630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71998/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71985/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71985 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71985/testReport)**
for PR 16630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16630
**[Test build #71985 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71985/testReport)**
for PR 16630 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
This test just resists to start. Could someone help? Many thanks!
@srowen @jkbradley @MLnick @yanboliang
---
If your project is set up for it, you can reply to this email and have your
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
The following code illustrates the idea of this PR.
```
val datasetWithWeight = Seq(
(1.0, 1.0, 0.0, 5.0),
(0.5, 2.0, 1.0, 2.0),
(1.0, 3.0, 2.0, 1.0),
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16630
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
80 matches
Mail list logo
