Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16652
gentle ping @admackin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16652
The core change is looking OK @admackin but seems like it fails Python
tests? if you have a moment to look at that, could be all that's needed to get
this over the line.
---
If your project is set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3554/testReport)**
for PR 16652 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3554/testReport)**
for PR 16652 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3552/testReport)**
for PR 16652 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3552/testReport)**
for PR 16652 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16652
looks good to me too. I just added a small suggestion. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3551/testReport)**
for PR 16652 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3551/testReport)**
for PR 16652 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16652
This is looking OK to me, but it needs a (squash, optionally, and) rebase
now before it can test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user admackin commented on the issue:
https://github.com/apache/spark/pull/16652
I've addressed all the problems I think â code style now fixed,
MLTestingUtils patched (and verified all MLLib test cases still pass), and
added a test case for zero-valued labels
---
If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3544/testReport)**
for PR 16652 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16652
**[Test build #3544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3544/testReport)**
for PR 16652 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16652
It looks like there is no particular reason that `("0", Vectors.dense(0, 2,
3), 0.0)` really needs to set a 0 value as the label. You could make it 1 and
see that it still passes all tests.
---
If
Github user admackin commented on the issue:
https://github.com/apache/spark/pull/16652
Yes thatâs right, in MLUtils it supplies zero-labels as test cases (ie
assumes theyâre allowed, which for other regression algorithms would be
true). More than happy to patch that instead
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16652
I imagine there's a better way to do this without copying code. Do you mean
the common test code assumes 0 labels are permitted? then maybe it should just
not do that, because it's just using any
Github user admackin commented on the issue:
https://github.com/apache/spark/pull/16652
Yes, the version in MLUtils had labels of zero in the test cases, so was
causing test cases to fail after my patch. It didn't look like there was a way
to fix this, so I thought it better to make
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16652
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
18 matches
Mail list logo
