Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
Great, done!
Looking forward to more contributions from you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Thanks for the reminder. I may have forgotten to mention that I am the
reporter of this JIRA bug. My JIRA ID is also titicaca. Thank you!
---
If your project is set up for it, you can reply to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16689
@titicaca he means, what is your user ID on JIRA? so we can credit you.
It's clear what the JIRA is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Yes. The JIRA id is SPARK-19342. Thank you for the help and advices :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
@titicaca do you have a JIRA id on https://issues.apache.org? We would
resolve the bug to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
great, this is a good catch and thank you for fixing this @titicaca
merging to master, branch-2.1
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16689
Ok - I think this sounds good then ! @felixcheung Let me know if you want
me to take a look at the code as well or if not feel free to merge when you
think its ready
---
If your project is set
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Yes, collect on timestamp was getting `c("POSIXct", "POSIXt")`. But when NA
exists at the top of the timetamp column, it was getting `numeric` as I
described in the PR description.
---
If your
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16689
@felixcheung @titicaca Just to make sure I understand, collect on timestamp
was getting `c("POSIXct", "POSIXt")` even before this change ?
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
hmm, this seems like a reasonable approach. With these changes:
- collect on timestamp would get `c("POSIXct", "POSIXt")`
- coltypes output will not change
@shivaram what do you
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Thanks. I tried to fix the method `coltypes` for the modification of the
timestamp, and it can pass all the tests now.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72378/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72378/testReport)**
for PR 16689 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72378/testReport)**
for PR 16689 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
hmm, that's not a super big issue since vector and list is more or less the
same in R.
I think it might be better if we are treating the type consistently,
although it might be a concerning
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
I tried to modify the PRIMITIVE_TYPES for timestamp, but it had a side
effect on coltypes method.
In test_sparkSQL.R#2262, `expect_equal(coltypes(DF), c("integer",
"logical",
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72250/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72250/testReport)**
for PR 16689 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72250/testReport)**
for PR 16689 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72186/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72186/testReport)**
for PR 16689 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72186/testReport)**
for PR 16689 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72182/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72182/testReport)**
for PR 16689 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #72182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72182/testReport)**
for PR 16689 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
Just to make sure you see this:
https://github.com/apache/spark/pull/16689#issuecomment-275063425
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
I have modified the codes and tests, including the existed tests
@test_sparkSQL.R#1280 and @test_sparkSQL.R#1282.
Like in local R, now NA column of the SparkDataFrame will also be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71982/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #71982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71982/testReport)**
for PR 16689 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #71982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71982/testReport)**
for PR 16689 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #71969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71969/testReport)**
for PR 16689 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71969/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16689
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16689
**[Test build #71969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71969/testReport)**
for PR 16689 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16689
Jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16689
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
great! @shivaram could you get Jenkins to test this fix please? I don't
seem to have the power to command it :)
---
If your project is set up for it, you can reply to this email and have your
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Sorry for the late reply. I figured out that the tests failed because if a
vector is with only NAs, the type is logical, therefore we cannot cast the type
in that case. I have updated the codes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
yes. but please see my other comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user titicaca commented on the issue:
https://github.com/apache/spark/pull/16689
Sure. Shall I add the tests in pkg/inst/tests/testthat/test_sparkSQL.R?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16689
Oh. it was all written in the PR description... I removed my uesless
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16689
(I might be wrong but was suspecting that it returns `NA` first as
`logical` when we collect via `SerDe.scala` and then it ends up `numeric` due
to the type coercion when `NA` is located first
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16689
Oh @felixcheung , I was writing a comment but I just saw you. I was looking
into this for my curiosity.
Isn't this due to R type coercion rule with POSIXlt?
```r
>
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16689
Thanks! I can verify this case and the fix.
Could you please add some tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
49 matches
Mail list logo
