Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16696
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74060/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #74060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74060/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #74060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74060/testReport)**
for PR 16696 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16696
LGTM except minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16696
LGTM except one minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16696
@cloud-fan Does this look good to you now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73845/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73845 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73845/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73845/testReport)**
for PR 16696 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73824/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73824/testReport)**
for PR 16696 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16696
@cloud-fan @gatorsmile I've updated this pr and also added test cases,
please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73391/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73391/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73391/testReport)**
for PR 16696 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73372/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73372/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #73372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73372/testReport)**
for PR 16696 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16696
Overall looks good to me. : ) Could you add a few more test cases?
- One is the child has less row counts than the limit.
- Another is having zero row counts but `sizeInBytes` is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16696
Sure, will review it tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71988/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71988/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71988/testReport)**
for PR 16696 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71964/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71964/testReport)**
for PR 16696 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71963/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16696
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71963/testReport)**
for PR 16696 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71964/testReport)**
for PR 16696 at commit
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/16696
cc @cloud-fan @gatorsmile please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16696
**[Test build #71963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71963/testReport)**
for PR 16696 at commit
41 matches
Mail list logo
