Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16697
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79310/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #79310 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79310/testReport)**
for PR 16697 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16697
LGTM, pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #79310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79310/testReport)**
for PR 16697 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16697
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16697
Should we merge this PR? @mridulm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77111/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #77111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77111/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #77111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77111/testReport)**
for PR 16697 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
Yes. If inside, you are right - only the first will be logged !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
you mean outside of
https://github.com/apache/spark/pull/16697/files#diff-ca0fe05a42fd5edcab8a1bdaa8e58db9R210?
---
If your project is set up for it, you can reply to this email and have your
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
`onDropEvent` is invoked for every dropped event : not just the first.
If all you need is a way to find out what the dropped events were - simply
enable trace logging for the class after
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
@mridulm but that still log the first dropped message, which cannot provide
enough evidence for debugging, right?
---
If your project is set up for it, you can reply to this email and have your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16697
@CodingCat is this still active and any opinion on ^?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
I probably did not convey my idea properly ...
What I meant was, the only change required be :
`logTrace(s"Dropping events $event")` in `def onDropEvent(event:
SparkListenerEvent): Unit`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73495/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #73495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73495/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #73495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73495/testReport)**
for PR 16697 at commit
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
@mridulm thanks, I have changed the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
@CodingCat Thinking more, I propose the following:
There are two changes here :
a) Changing the log message in onDropEvent()
If the queue is getting swamped due to a
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
@mridulm what I thought is that logging the events which are sampled
from the timeline may not provide meaningful info to the user
the current implementation will clean the events queue
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
Instead of keeping track of the history of dropped events, which will
become expensive very fast, how about logging the current event (if dropped)
when we log at
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72138/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72138/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72138/testReport)**
for PR 16697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72135/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72135 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72135/testReport)**
for PR 16697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72134 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72134/testReport)**
for PR 16697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72134/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72133/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72133/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72135 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72135/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72134 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72134/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #72133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72133/testReport)**
for PR 16697 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/16697
This PR will log only the first event which got dropped.
The first event which got droped need not necessarily have a correlation to
the actual event(s) flooding the queue.
The PR
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
@srowen mind looking at it? it's a simple improvement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71993/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #71993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71993/testReport)**
for PR 16697 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #71993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71993/testReport)**
for PR 16697 at commit
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/16697
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71965/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16697
**[Test build #71965 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71965/testReport)**
for PR 16697 at commit
52 matches
Mail list logo
