[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-06-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16747 @terma To avoid confusing the Spark SQL users, we might not document it? How about closing this PR now? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16747 CC @rxin, if we are going to expose `CalendarInterval` and `CalendarIntervalType` officially, shall we move `CalendarInterval` to the same package as `Decimal`, or create a new class as the

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16747 Then, It looks okay to me as describing the current state and I just checked it after building the doc with this, and also we can already use it as below: ```scala scala>

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16747 Actually `CalendarInterval` is already exposed to users, e.g. we can call `collect` on a DataFrame with `CalendarIntervalType` field, and get rows containing `CalendarInterval`. We don't support

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16747 ^ I want to be very sure if we are not going to expose this or not. Could any SQL committer guy or PMC confirm this? > `CalendarIntervalType` only for compatibility with similar type in

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread terma
Github user terma commented on the issue: https://github.com/apache/spark/pull/16747 @srowen As I understood ```CalendarIntervalType``` only for compatibility with similar type in ```Hive```. So probably better to mark it as internal and close jira? --- If your project is set up

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16747 (FWIW, I am OK but just worried if it might be supposed to be internal type, maybe in the future) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16747 It seems there are several ones here and there. Maybe https://github.com/apache/spark/pull/15751#issuecomment-258518577 is related too because it is about supporting reading/writing out that

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-02-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16747 CC @cloud-fan for https://github.com/apache/spark/pull/13008#r62947902 and @yhuai for https://github.com/apache/spark/pull/8597#r38769233 as they might be what you're referring to? --- If your

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-01-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16747 I am OK but I remember there are some discussions about whether this type should be exposed or not and I could not track down the conclusion. --- If your project is set up for it, you can

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-01-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16747 @HyukjinKwon is this OK by you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16747: SPARK-16636 Add CalendarIntervalType to documentation

2017-01-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16747 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this