Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16949
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73309/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #73309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73309/testReport)**
for PR 16949 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #73309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73309/testReport)**
for PR 16949 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
cc @srowen and @vanzin also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
cc @srowen also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16949
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73145/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #73145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73145/testReport)**
for PR 16949 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
cc @vanzin Take a second review please!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #73145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73145/testReport)**
for PR 16949 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
@vanzin @ajbozarth sure, I will check related code in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16949
Thanks @uncleGen and after seeing his code I agree with @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16949
Sure, this PR is fine, I'd just prefer some minor API adjustments to bring
it closer to the code I linked above.
---
If your project is set up for it, you can reply to this email and have your
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
@vanzin I opened a jira (https://issues.apache.org/jira/browse/SPARK-19642)
to research and address the potential security flaws. Do you mind if I continue
this pr?
---
If your project is set up
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16949
re: security, this change doesn't really change anything; all this
information is already available in the UI. Note it doesn't expose the system
env (as in environment variables), although people
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/16949
@uncleGen As followup I'd recommend opening a JIRA to research and address
the potential security flaws in the env tab. I know we've already merged some
fixes to hide passwords in the env tab,
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
@srowen good questionï¼IMHOï¼we should add this API:
- provide complete API, the same as users see in webui
- if this is a security issue, we should address it in other ways
-
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16949
It's a simple change, but I wonder if this is that important to add?
I always have a worry in the back of my mind that this becomes a security
hole, as it's a way to look through the complete
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72989/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #72989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72989/testReport)**
for PR 16949 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #72989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72989/testReport)**
for PR 16949 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
terminated by signal 9. retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72986/
Test FAILed.
---
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
cc @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #72986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72986/testReport)**
for PR 16949 at commit
Github user uncleGen commented on the issue:
https://github.com/apache/spark/pull/16949
jenkins crushed. retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72979/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16949
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #72979 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72979/testReport)**
for PR 16949 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16949
**[Test build #72979 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72979/testReport)**
for PR 16949 at commit
35 matches
Mail list logo
