Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Thank you @holdenk, @viirya and @ueshin.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Thanks, merged to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81488/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #81488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81488/testReport)**
for PR 17096 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #81488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81488/testReport)**
for PR 17096 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Sorry for the delay. Lets get Jenkins to retest this and make sure
everything is ok but it looks like a good change :)
LGTM pending jenkins/merge issues (if they show up during jenkins).
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
gentle ping ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79038/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #79038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79038/testReport)**
for PR 17096 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #79038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79038/testReport)**
for PR 17096 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
@HyukjinKwon Pretty much, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Do you mean a test case such as
`self.assertEqual(testParams._resolveParam(u"ì"), testParams.ì)
` ?
---
If your project is set up for it, you can reply to this email and have your
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
I'd really like to see that further test I was talking about, @HyukjinKwon
-- it shouldn't be too hard to do in this pr right? Just add a unicode string
which doesn't make sense in down converted
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Yea, I was waiting for the feedback. It is also about the unicode vs byte
string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/17096
@HyukjinKwon @holdenk Hi, are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Hey @holdenk. I am willing to close this for now if you are not confident
enough for merging it for now. I can re-open this later.
---
If your project is set up for it, you can reply to this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Thanks for taking the time to review this @viirya :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Thank you @viirya for your sign-off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17096
Remaining changes LGTM. cc @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73822/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #73822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73822/testReport)**
for PR 17096 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
@holdenk and @viirya, I got rid of the changes in `types.py` and only left
that I am pretty sure.
There are two kind of changes here that look used in the only local scope.
One
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #73822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73822/testReport)**
for PR 17096 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Let me check if each is fine for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
@viirya, thank you so much for taking a look and your time.
So, basically, the second case it compares str to unicode as below:
```python
>>> u"測試" ==
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17096
In `StructType.add`, if the given field name is a `basestring`, we will
directly use it as key in `names` property.
If we pass in a `StructField`, we take `StructField.name` as key in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73688/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #73688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73688/testReport)**
for PR 17096 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #73688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73688/testReport)**
for PR 17096 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17096
Thank you @viirya. I think it is ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17096
Few minor comments. Overall looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Let's double check with @viirya to make sure his comment was addressed, but
I really appreciate the improved test coverage :)
---
If your project is set up for it, you can reply to this email and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17096
Thank you for taking this over @HyukjinKwon :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17096
**[Test build #73579 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73579/testReport)**
for PR 17096 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73579/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17096
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
41 matches
Mail list logo
