Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17108
Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75118/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #75118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75118/testReport)**
for PR 17108 at commit
Github user thunterdb commented on the issue:
https://github.com/apache/spark/pull/17108
Tickets created:
- https://issues.apache.org/jira/browse/SPARK-20076
- https://issues.apache.org/jira/browse/SPARK-20077
---
If your project is set up for it, you can reply to this
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17108
LGTM will merge after tests
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #75118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75118/testReport)**
for PR 17108 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17108
LGTM except for the one doc nit.
When you update this, could you also please make and link JIRAs for the
Python wrapper and doc update?
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75060/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #75060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75060/testReport)**
for PR 17108 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #75060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75060/testReport)**
for PR 17108 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17108
the code looks good to me, I added some minor comments, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17108
Taking a look now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74627/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #74627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74627/testReport)**
for PR 17108 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74626/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #74626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74626/testReport)**
for PR 17108 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #74627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74627/testReport)**
for PR 17108 at commit
Github user thunterdb commented on the issue:
https://github.com/apache/spark/pull/17108
I moved the code `Correlations` as suggested. @imatiach-msft , I addressed
your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #74626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74626/testReport)**
for PR 17108 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17108
Given further thought, I'd prefer we stick to the API specified in the
design doc, with a Correlations object instead of a generic Statistics object.
In the future, we may want optional Params
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17108
The changes look good to me. I just had a few minor comments. I wish we
could just natively implement the correlations in spark to avoid extra copying
between the old and new
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73627/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #73627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73627/testReport)**
for PR 17108 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17108
**[Test build #73627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73627/testReport)**
for PR 17108 at commit
29 matches
Mail list logo
