Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17110
OK merging with master
Thanks @imatiach-msft and @thunterdb !
@imatiach-msft I agree about sparse testing. This has all of the MLlib
tests, but we should add more in the
Github user thunterdb commented on the issue:
https://github.com/apache/spark/pull/17110
@jkbradley LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17110
I guess my only concern would be the testing is a bit sparse, but more
tests can be added in the future (especially when the MLlib part is removed).
It seems it would be better to move more
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17110
Ping @imatiach-msft any more comments after the update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17110
LGTM! nice addition :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74227/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17110
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17110
**[Test build #74227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74227/testReport)**
for PR 17110 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17110
**[Test build #74227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74227/testReport)**
for PR 17110 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17110
I just reversed my opinion about a shared "Statistics" object. See
https://github.com/apache/spark/pull/17108#issuecomment-285200613 for details.
I pushed an update per your review
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/17110
cool, I'll hold off on reviewing this for now then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17110
Actually, synced with @thunterdb and will update design doc to put
everything under a "Statistics" object. I'll wait until
https://github.com/apache/spark/pull/17108 gets merged.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73644/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17110
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17110
**[Test build #73644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73644/testReport)**
for PR 17110 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17110
**[Test build #73644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73644/testReport)**
for PR 17110 at commit
16 matches
Mail list logo
