[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2018-04-13 Thread sijunhe
Github user sijunhe commented on the issue: https://github.com/apache/spark/pull/17359 Would love to see this feature in Spark SQL. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-10-10 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 Sorry, but I think this is inactive. Thanks for your attention. @wzhfy @viirya @gatorsmile --- - To unsubscribe, e-mail:

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17359 @gatorsmile I will try to take a look again. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-10-03 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17359 @gatorsmile Sure, I haven't read the context, but it's been nearly half a year since last update, is this PR still active @gczsjdy ? ---

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-10-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17359 cc @wzhfy @viirya Are you interested in reviewing this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17359 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17359 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-04-27 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 @viirya Updated, as the last sentence mentioned, I have tried to make Spark support `GenericUDAFResolver`. But it lacks some interfaces comparing with `AbstractGenericUDAFResolver` so this can't be

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-04-26 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 @viirya Sorry for the late reply. It seems Spark cannot use Hive `GenericUDAFnGrams`, since Spark only supports subclass of `AbstractGenericUDAFResolver` & `UDAF` for Hive UDAF, while

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-04-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17359 Regarding the performance issue, does this change have significant improvement compared with Hive's? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-04-09 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 @rxin @cloud-fan @gatorsmile @viirya @tejasapatil Could you please help me review this PR? Or is there anything I can do on this work? --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-03-24 Thread chenghao-intel
Github user chenghao-intel commented on the issue: https://github.com/apache/spark/pull/17359 @rxin nGram is the built-in UDAF in Hive, and some users complaints they faced performance issue when running the queries with nGram. --- If your project is set up for it, you can reply to

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-03-23 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 @rxin My fault, the example I gave is far from practical use and I have updated. Actually, we can use it whenever the text analysis is reasonable to be based on frequencies of word sequences. For

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-03-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17359 Why do we want this? Seems extremely low usage on this function in the wild. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17359: [SPARK-20028][SQL] Add aggreagate expression nGrams

2017-03-20 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/17359 cc @chenghao-intel @yucai @adrian-wang @cloud-fan @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does