Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
Thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen do you feel this patch could be merged now ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
Is there anything else that can be done on this patch. The patch fixes all
the deprecated api testcases that try to use the aws secret/id credentials
instead of the builder.
---
If your project
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
Thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17506
**[Test build #75566 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75566/testReport)**
for PR 17506 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17506
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75566/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17506
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
It does retrigger automatically but you need to push commits.
Hm, it may be that somehow the kinesis code isn't passing style checks and
wasn't caught? because it's not generally tested unless
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17506
**[Test build #75566 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75566/testReport)**
for PR 17506 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen - does the Jenkins re-test trigger automatically?
else, could I request a retest on this patch please ?
---
If your project is set up for it, you can reply to this email and have your
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen : It failed on the earlier patch with KinesisTestUtils.scala
changes. This version is clean. Will wait for the next automated build :)
Build logs:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
@yssharma you can't check in code that fails style checks. The existing
code passes the checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
The Scala style check fail because of the double spaced lines probably. But
that's how the existing code was so thought of keeping it that way.
---
If your project is set up for it, you can reply
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen - Thanks for the feedback. Appreciate it. Added a minimal
simplified patch which fixes the testcases that fail with the old api.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17506
**[Test build #3635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3635/testReport)**
for PR 17506 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17506
**[Test build #3635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3635/testReport)**
for PR 17506 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
Why would you disable old API tests here? the primary purpose is not
calling deprecated APIs in tests where it's not needed. Best thing is to just
do that. If you happen to add a new test or two
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen - Yes, 2 objectives for the patch:
- add new testcases for new api (that also tests aws session tokens)
- ability to disable old api test cases
For now I have added new test
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17506
So, is the point just removing calls to a deprecated API? It doesn't seem
like it needs to be this complicated.
If a test is not specifically intended to test the deprecated API, then it
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/17506
@srowen - Have made following improvements to the patch to incorporate your
points:
- Did not remove old testcases for keeping the checks on old api
- Added new testcases that test the new
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17506
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
23 matches
Mail list logo
