Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17590
Sure, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17590
merged to master.
@HyukjinKwon would you like to follow up and change `asJsonArray` in master?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17590
Thanks @HyukjinKwon for addressing this and @actuaryzhang for chiming in.
I definitely think this is the right step to take and we could use more
documentation in terms of specific style
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/17590
I think @HyukjinKwon interpretation is good !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17590
This is my thought on it.
- **variable names**
in [SPARK-6813](https://issues.apache.org/jira/browse/SPARK-6813) ...
> We could have a R style guide based on the one from
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17590
The change is fine to me. With this, we can define function/argument names
using multiple styles such as `as.json.array`, `as_json_array`, `asJsonArray`.
Is there a preferred style among
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17590
I think it is because it only checks multiple dots and the case I described
above was finally found now (in my previous PR related with `from_json`
function).
I think multiple dots are
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17590
Changes look fine. I think we should get some feedback on style/guideline
changes like this though.
Also do you know why we don't ever see these types of error in Jenkins? Is
it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17590
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75656/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17590
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17590
**[Test build #75656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75656/testReport)**
for PR 17590 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17590
**[Test build #75656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75656/testReport)**
for PR 17590 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17590
cc @felixcheung, could you take a look and see if it makes sense to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
13 matches
Mail list logo
