Github user superbobry commented on the issue:
https://github.com/apache/spark/pull/17746
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/17746
@superbobry As you can see in this PR, one of them is
```scala
-override def link(mu: Double): Double = dist.Gaussian(0.0,
1.0).icdf(mu)
+override def link(mu: Double):
Github user superbobry commented on the issue:
https://github.com/apache/spark/pull/17746
@srowen thanks! I've missed the point that 0.13.1 was intentionally merged
into the upcoming release.
@dbtsai could you give an example of the breaking API change between 0.12
and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17746
@superbobry see the discussion above? doesn't seem safe to do so
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user superbobry commented on the issue:
https://github.com/apache/spark/pull/17746
Hello, are there any plans to backport this into 2.1 branch? The LBFGS and
other fixex in 0.13.1 seem important enough.
---
If your project is set up for it, you can reply to this email and
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/17746
@dbtsai Thanks for the explanation and the context :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/17746
The motivation to have this one merged in Spark 2.2 is not only just for
#17715 but also because Breeze 0.13.x fixes many bugs in upstream. Since Spark
was tightened to 0.12, many users (including
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17746
+10 for not merging major changes like this so close to the release,
especially after an RC has been cut, unless it's for blocker bugs. Same for
new APIs such as
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/17746
Can I ask how we decided merging this dependency change after the cut of
the release branch (especially this change affects user code)?
---
If your project is set up for it, you can reply to this
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/17746
@srowen Couple APIs changes in Breeze 0.13 are not source code compatible
with 0.12. We should tell users about that in the release note, and they need
to do their migration if they are using Breeze
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17746
Not that I have any specific concern, but did anyone look at the changes
from 0.12 to 0.13 to see if anything might be breaking? probably not, but it
does leak into the user classpath
---
If your
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/17746
Many thanks for @WeichenXu123 helping to fix this bug in breeze!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/17746
LGTM. Merged into master and branch 2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76110/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17746
**[Test build #76110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76110/testReport)**
for PR 17746 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17746
cc @dbtsai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17746
**[Test build #76110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76110/testReport)**
for PR 17746 at commit
18 matches
Mail list logo
