[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/17935 The reason I found out about this is because the one of the widely circulated TPC-DS benchmark harness online uses this. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 Sorry, to be accurate, for the syntax of derived table in SQL, the databases I listed above are commonly seen in the market, and they don't support it without alias name. SQL 2003 grammar also

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/17935 I don't think that argument is useful at all. For example, none of the other databases support the DataFrame API. Does that mean few users will write DataFrame code? --- If your project is set up

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 I'm ok to revert this. Just a little reference. Seems it is required to have alias name for derived table: https://github.com/ronsavage/SQL/blob/master/sql-2003-2.bnf#L2221 And

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/17935 Other committers please revert this change until we find a solution or verify that almost no users write queries like this. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 @rxin Sorry I forgot to change JIRA ticket. I changed it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/17935 Also the description / title is completely different from the JIRA ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/17935 Guys - isn't this API breaking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/17935 @ash211, I was attempting to re-use test cases from CockroachDB (which is surprisingly permissive in the SQL it accepts compared to Postgres). --- If your project is set up for it, you can reply

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user ash211 commented on the issue: https://github.com/apache/spark/pull/17935 @JoshRosen what was the other type of database you were using? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 @JoshRosen Thanks for filing this issue. I'll look into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/17935 I was trying to run a test case from another database which _does_ support unaliased subqueries in the `FROM` clause and hit a confusing parser error due to this patch's behavior change. While I

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 No problem. The new commit passes tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17935 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77007/ Test PASSed. ---

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #77007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77007/testReport)** for PR 17935 at commit

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 Thanks @cloud-fan @hvanhovell @gatorsmile @wzhfy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 @cloud-fan Yeah, I change the aliased name in one test. I tested it locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17935 oops, you pushed a new commit... But it should be fine as the change is very small. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17935 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #77007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77007/testReport)** for PR 17935 at commit

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 Sure. On May 17, 2017 12:10 PM, "Wenchen Fan" wrote: > *@cloud-fan* commented on this pull request. > -- > > In

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17935 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17935 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76994/ Test PASSed. ---

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #76994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76994/testReport)** for PR 17935 at commit

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #76994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76994/testReport)** for PR 17935 at commit

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17935 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76969/ Test FAILed. ---

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #76969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76969/testReport)** for PR 17935 at commit

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17935 **[Test build #76969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76969/testReport)** for PR 17935 at commit