Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Sure, please close it as you wish. I will reopen it when it is ready for up
to date.
Sent from Mail Master
On 10/28/2017 07:39, Xiao Li wrote: @LantaoJin Maybe close it now? You can
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
@LantaoJin Maybe close it now? You can reopen it when the comment is
resolved?
---
-
To unsubscribe, e-mail:
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
@HyukjinKwon Sure. Thank you for reminding me. I almost forgot it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17953
@LantaoJin do you have some time to address the review comment above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77766/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77766/testReport)**
for PR 17953 at commit
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
@cloud-fan Do you think it should be done in this pull? And where should
add the filter, `CalalogImpl.createTable()` or `ExternalCatalog.createTable()`
---
If your project is set up for it, you
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77766/testReport)**
for PR 17953 at commit
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Ahh, found it. Re-generated the golden files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
All failed tests due to mis-match of *.sql.out with the new "void" simple
string of NullType.
How to re-generate them again?
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77723/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77723/testReport)**
for PR 17953 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17953
oh actually users can still create a table with null type column via
`Catalog.createTable`, seems it's ok to support "void" in our parser, but add a
new rule to throw exception if users wanna
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17953
I think a safer fix is to just handle "void" specially in
`HiveClientImpl.fromHiveColumn`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17953
shall we add a test case for `CREATE TABLE t(a void)` to make sure it still
fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77723/testReport)**
for PR 17953 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17953
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
retest this commit please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Thanks @gatorsmile , I took a vacation last week. Will update it ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
ping @LantaoJin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
LGTM except two comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77150/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77150/testReport)**
for PR 17953 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77150/testReport)**
for PR 17953 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17953
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77115/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Thanks @cloud-fan . Hi @hvanhovell and @gatorsmile , any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77115/testReport)**
for PR 17953 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17953
I don't think we should support `void` type in the parser, `CREATE TABLE
t(a void)` should still be illegal.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77002/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77002/testReport)**
for PR 17953 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77000/testReport)**
for PR 17953 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77000/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77002/testReport)**
for PR 17953 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77001/testReport)**
for PR 17953 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77001/
Test FAILed.
---
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Thanks, I add a row to the table `t` and now we can do nonEmpty check on
table `tabNullType`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77001/testReport)**
for PR 17953 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #77000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77000/testReport)**
for PR 17953 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
After this PR, we can describe it, but the query results are still empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76968/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76968/testReport)**
for PR 17953 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76968/testReport)**
for PR 17953 at commit
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
Add a test in HiveDDLSuite. Please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
Maybe `HiveDDLSuite`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/17953
@gatorsmile Yes, it's the right test scenario. Which class should I add to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17953
Are your test scenario is like?
```Scala
withTable("t", "tabNullType") {
val client =
spark.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76866/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76866 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76866/testReport)**
for PR 17953 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76866 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76866/testReport)**
for PR 17953 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17953
@LantaoJin Can you add a description and a test case for this? You can take
a look at the OrcSourceSuite to get an idea how to work with Hive.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76834/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76834/testReport)**
for PR 17953 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17953
**[Test build #76834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76834/testReport)**
for PR 17953 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17953
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17953
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
69 matches
Mail list logo
