[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2018-06-12 Thread rkarimi
Github user rkarimi commented on the issue: https://github.com/apache/spark/pull/17972 perhaps related: Big Random Forest Models (example: 100 or more trees with depth of around 20): Big models can be trained effectively even on machines with limited RAM (such

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-18 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @WeichenXu123 resolved merge conflicts. Can you initiate jenkins build? --- - To unsubscribe, e-mail:

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-15 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 Can you please initiate the Jenkins build? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 I have added to all the algorithms I know that uses intermediate state. --- - To unsubscribe, e-mail:

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-13 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17972 Have you checked other algorithms which can also apply this parameter ? --- - To unsubscribe, e-mail:

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-11-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @WeichenXu123 Done the changes to mima. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-08-09 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 There are around 33 binary incompatibility issues as I made this a shared param. Some of them from build logs are below ```scala [error] * abstract synthetic method

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77498/ Test FAILed. ---

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17972 **[Test build #77498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77498/testReport)** for PR 17972 at commit

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17972 **[Test build #77498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77498/testReport)** for PR 17972 at commit

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17972 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-29 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick i am working on fixes you recommended. Meantime jenkins build doesn't seems to be started. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-25 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17972 Ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-24 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick can you start a jenkins build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-24 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 I have updated the code to have the parameter in sharedParamsCodeGen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-17 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17972 Yes let's make it shared if possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-16 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 @MLnick should i go ahead and move it to SharedParamsCodeGen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-15 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17972 If other algos are going to use this param, we should put in in shared params - i.e. update `SharedParamsCodeGen` and have the relevant estimators inherit from the trait. --- If your project is

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17972 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17972: [SPARK-20723][ML]Add intermediate storage level to tree ...

2017-05-13 Thread phatak-dev
Github user phatak-dev commented on the issue: https://github.com/apache/spark/pull/17972 Current unit test case is rudimentary. Any help in improving it is appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.