Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
Sorry, I accidentally deleted the code branch. I'm going to close this PR.
I created a new PR https://github.com/apache/spark/pull/19346, which was
modified and created based on the latest
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18015
There's still left comment not addressed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18015
I think @jerryshao is an active committer who knows this one better than
me. Since he is here, let me leave it to him.
---
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@HyukjinKwon
Help merge to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/18015
Still LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82072/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #82072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82072/testReport)**
for PR 18015 at commit
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
And failed, who submitted the code in question.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #82072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82072/testReport)**
for PR 18015 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18015
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
This Jenkins error is not caused by this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18015
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82064/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #82064 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82064/testReport)**
for PR 18015 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18015
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #82064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82064/testReport)**
for PR 18015 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18015
Yes, I'm fine with it. @ajbozarth would you please take another look on
this PR? Thanks.
---
-
To unsubscribe, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18015
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18015
Hi @jerryshao, do you maybe have a preference? To me, I don't have a strong
preference but I think I am okay with this.
---
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@gatorsmile
Help to merge to master , Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@gatorsmile
Help to merge to master , Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
Sir, if so, I do not know how to deal with it.
But I really feel like this change, which makes spark SQL UI good. If you
agree with this JIRA, I also plan to add this function
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18015
I don't support this but don't object of someone else merges
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
Help to merge to master , Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
Sir, what about the PR need to be modified?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
SQL ui is really different from other ui. In the follow-up version, I will
strive to improve the function of SQL ui.
---
If your project is set up for it, you can reply to this
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18015
Yes I understand that, but I don't think the reasoning is as compelling
here, and the style is a bit different.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
I think the style exists to provide links that jump to Running Queries or
Completed Queries because it may be well below the fold if there are many
workers.Job page, stage page,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18015
I don't think those links are worth the vertical space they chew up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
Help to merge to master and modify the status about
https://issues.apache.org/jira/browse/SPARK-20785.Thanks.
---
If your project is set up for it, you can reply to this email
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen Help to merge to master and modify the status about
https://issues.apache.org/jira/browse/SPARK-20785.Thanks.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3764/testReport)**
for PR 18015 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3764/testReport)**
for PR 18015 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3761/testReport)**
for PR 18015 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3761/testReport)**
for PR 18015 at commit
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@SparkQA
please test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3758/testReport)**
for PR 18015 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18015
**[Test build #3758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3758/testReport)**
for PR 18015 at commit
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@HyukjinKwon Thanks.
@srowen Help to merge to master and modify the status about
https://issues.apache.org/jira/browse/SPARK-20785.Thanks.
---
If your project is set up for it, you
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18015
@guoxiaolongzte I can't. I am just a contributor like yo. I could say +1 :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@HyukjinKwon
Help to merge to master and modify the status about
https://issues.apache.org/jira/browse/SPARK-20785.Thank you.
---
If your project is set up for it, you can reply to
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen
Help to merge to master and modify the status about
https://issues.apache.org/jira/browse/SPARK-20785.Thank you.
---
If your project is set up for it, you can reply to this
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
Thank you, I will work better for Spark web ui.
jenkins to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@ajbozarth
Thank you very much for the suggestion that I have modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@ajbozarth
Rebuild, optimize the variable name.
I add two screenshots.Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18015
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/18015
@srowen @ajbozarth
Help to review the code, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
47 matches
Mail list logo