[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18142 @gatorsmile btw, we've already file a lira to track these kinds of all the SQL-compiliant issues? not yet? --- - To unsubscribe,

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 Yea, I didn't mean it super seriously @cloud-fan - I just left a comment in case for a better documentation since I see many users go from Hive to Spark. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 > Spark SQL is designed to be compatible with the Hive Metastore, SerDes and UDFs. This is different from `Spark can run any Hive SQL`. Spark can load and use Hive UDFs, with the right

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 I mean https://spark.apache.org/docs/latest/sql-programming-guide.html#supported-hive-features and

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18142 We do not need to follow Hive if Hive does not follow SQL compliance. Our main goal is to follow the mainstream DBMS vendors. BTW, we can enhance our parser to recognize the other

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 > BTW, I believe there's no particular standard for backticks themselves since different DBMS uses different backtick implementations. You are right, but SQL standard does define how to

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 One explicit problem here is, we claim Hive compatibility in Spark. The difference should be explained when we are clear on this. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 > This clearly violates the SQL semantic: the string inside backticks should be treated as a string literal. BTW, I believe there's no particular standard for backticks themselves

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 Yea that was my impression as well. Let me bring this back when we're clear if this is a bug or not. --- - To unsubscribe,

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 After a second thought, isn't it a bug? ``` hive> SELECT `d100.udf100`(`emp`.`name`) FROM `emp`; USER ``` This clearly violates the SQL semantic: the string inside

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 @cloud-fan, should we update migration guide as well? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18142 I see. Thanks for the note. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 hmm, then it's too late. Maybe we can add it in Spark 2.3.2, cc @jerryshao --- - To unsubscribe, e-mail:

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18142 BTW, this is changed at Spark 2.3.0. How did we handle this before? --- - To unsubscribe, e-mail:

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 I agree with this change too for clarification. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 @HyukjinKwon Thanks for the note! I think this behavior is better, I'm adding a `release_note` tag to the JIRA ticket, so that we don't forget to mention it in release notes. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2018-09-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18142 I am leaving a note (at least to myself) since it looked anyhow caused behaviour change. With this statements in Hive side: ```sql CREATE TABLE emp AS SELECT

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18142 Guys - please in the future separate bug fixes with refactoring. Don't mix a bunch of cosmetic changes with actual bug fixes together. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18142 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77825/ Test PASSed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77825/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77825/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77815/ Test PASSed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77815/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77815/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-06-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18142 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77602/ Test PASSed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77602/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77602/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77538/ Test PASSed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77538/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77538/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77519/ Test FAILed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77520/ Test FAILed. ---

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18142 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77520/testReport)** for PR 18142 at commit

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77519/testReport)** for PR 18142 at commit