Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
LGTM
Let us resolve the issue as the follow-up PR.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82925/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82925/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82925/testReport)**
for PR 18270 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
@cenyuhai Could you also address this comment:
https://github.com/apache/spark/pull/18270/files#r136121931?
---
-
To
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
@gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82543/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82543/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82543/testReport)**
for PR 18270 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82540/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82540 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82540/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #82540 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82540/testReport)**
for PR 18270 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18270
Thanks for notification. Actually we implement the same logic with hive,
though there's a bug ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81345/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81345/testReport)**
for PR 18270 at commit
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
@jinxing64 I think you may revert the changes in Spark, and use the same
logic of grouping__id as hive. Keep the wrong result consistently as hive did.
---
If your project is set up for it, you
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81345/testReport)**
for PR 18270 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81342/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81342/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81342/testReport)**
for PR 18270 at commit
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
@gatorsmile I had already tried to resolve grouping__id in
ResolveFunctions. But ResolveFunctions is behind ResolveGroupingAnalytics.
grouping__id may change in ResolveGroupingAnalytics.
---
If
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
why failed? Couldn't I add order byï¼
```java
org.scalatest.exceptions.TestFailedException: Expected "...Y CUBE(course,
year)[ ORDER BY grouping__id, course, year]", but got "...Y
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81289/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81289/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81289/testReport)**
for PR 18270 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
That commit is the code changes I suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
I can't see any comment at 77d4f7c?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81262/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81262 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81262/testReport)**
for PR 18270 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
See the commit I made here:
https://github.com/apache/spark/commit/77d4f7c4842d1b27f5a48a18fa55fa6c01016d42
---
If your project is set up for it, you can reply to this email and have your
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18270
Thank you so much !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
@jinxing64 https://github.com/apache/spark/pull/10677 made the changes.
Hive generates a wrong result. See the JIRA opened by Davies:
https://issues.apache.org/jira/browse/HIVE-12833
---
If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81262 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81262/testReport)**
for PR 18270 at commit
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18270
@gatorsmile
Could you please give some ideas why the value of `grouping_id()` generated
in Spark is different from `grouping__id` Hive? Is it designed on purpose? A
lot of our users are
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81258/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81258/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81258/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81257/testReport)**
for PR 18270 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81257/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #81257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81257/testReport)**
for PR 18270 at commit
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
Okï¼I will update it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18270
@cenyuhai Could you update this PR? I will review it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user YannByron commented on the issue:
https://github.com/apache/spark/pull/18270
I realize the reason that leads to UTs failure is that the query result has
a fixed order even though a sql statement doesn't include `order by`, such as
the output of query 16 in
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18270
@cenyuhai
Are you still working on this? Could please fix the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80905/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #80905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80905/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #80905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80905/testReport)**
for PR 18270 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18270
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80086/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #80086 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80086/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #80086 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80086/testReport)**
for PR 18270 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18270
Ping, @cenyuhai .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18270
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78582/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #78582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78582/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #78582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78582/testReport)**
for PR 18270 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78312/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #78312 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78312/testReport)**
for PR 18270 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18270
Thank you, @shaneknapp .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #78312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78312/testReport)**
for PR 18270 at commit
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18270
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18270
i will retrigger this once jenkins restart
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78305/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #78305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78305/testReport)**
for PR 18270 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18270
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cenyuhai commented on the issue:
https://github.com/apache/spark/pull/18270
why it failedï¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77913/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #77913 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77913/testReport)**
for PR 18270 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18270
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77893/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #77893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77893/testReport)**
for PR 18270 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18270
**[Test build #77893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77893/testReport)**
for PR 18270 at commit
90 matches
Mail list logo
