Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@jkbradley @mgaido91 I just sent #19648 to move test data to data/mllib,
please feel free to review it. Thanks.
---
-
To
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 Don't worry, I'll post a follow-up PR for discussion in a few
days. Thanks.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18538
@jkbradley I am not sure that we should put the data for tests of the ml
package in the mllib package. Is this the right approach?
---
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/18538
@yanboliang @mgaido91 I just saw this PR. It creates a new test data
directory. Could you please send a quite update to move the data to the
existing data directory:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18538
@yanboliang yes, thank you very much.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 I opened
[SPARK-21981](https://issues.apache.org/jira/browse/SPARK-21981) for Python
API, would you like to work on it? Thanks.
---
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
I'm merging this into master, thanks for all. If anyone has more comments,
we can address them in follow-up PRs.
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18538
@yanboliang I addressed them. Thank you very much for your time, help and
your great reviews.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81666/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81666/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81666/testReport)**
for PR 18538 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 These are my last comments, it should be ready to merge once they
are addressed. Thanks for your contribution.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81639/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81639/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81639/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81463/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81463 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81463/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81463 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81463/testReport)**
for PR 18538 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 I left some minor comments, otherwise, this looks good. Thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81369/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81369/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81369/testReport)**
for PR 18538 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18538
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18538
the build error is caused by some file being present unexpectedly for
SparkR. This issue is unrelated with the PR (which doesn't even affect SparkR).
I am not sure whether someone is working on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81316/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81316/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81316 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81316/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81287/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81287/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #81287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81287/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80862/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80862/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80862/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80860/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80860/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80860/testReport)**
for PR 18538 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 I made another pass and left some comments, mainly about naming
and annotation. This looks in good shape now. I'd suggest to following the name
in sklearn, which should be easy to
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18538
@yanboliang thanks for your review.
I refactored the code according to your suggestions and I removed the
cosine implementation.
Might you please review it now?
Thanks.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80453/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80453 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80453/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80453/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80285/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80285/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80285 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80285/testReport)**
for PR 18538 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80281/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80281/testReport)**
for PR 18538 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18538
**[Test build #80281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80281/testReport)**
for PR 18538 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18538
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18538
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18538
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@gatorsmile Could you help to trigger the test job? It seems I can't do it
now. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18538
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
65 matches
Mail list logo
