[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2018-11-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18697 Let't close this then. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2018-07-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18697 @aray Can you close this for now because it's not active for a long time? (I'm not sure the current master still has this issue..., so you should check it first) ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-09-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18697 If we have correct `outputPartitioning` on each operators, I think this issue can be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-09-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18697 shouldn't we fix `ProjectExec.outputPartitioning`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81286/ Test PASSed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #81286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81286/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #81286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81286/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #81284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81284/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81284/ Test FAILed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #81284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81284/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80080/ Test PASSed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #80080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80080/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18697 @viirya We could certainly make that improvement. I believe it would be a fairly trivial change to this PR if we were just considering expressions that have the same canonical representation. However

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #80080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80080/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18697 A different view to this problem is, in the following part of query plan: :- *HashAggregate(keys=[parent#228], functions=[], output=[level1#270]) hashpartitioning(parent#228, 5)

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-31 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18697 I'd like to reword the problem description as the current one looks obscure to me. Currently we don't care if the output partitioning of an operator contains the attributes not in the

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18697 I will review this next week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18697 cc @cloud-fan @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-25 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18697 ping @rxin can someone look at this correctness fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79836/ Test PASSed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79836/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79836/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18697 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79823/ Test FAILed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79823/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79823/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79822/ Test FAILed. ---

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18697 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79822/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18697 **[Test build #79822 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79822/testReport)** for PR 18697 at commit

[GitHub] spark issue #18697: [SPARK-16683][SQL] Repeated joins to same table can leak...

2017-07-20 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18697 Plan for the example query before the patch (with partitioning as suffix): ``` *HashAggregate(keys=[parent#228], functions=[], output=[level2#274]) hashpartitioning(parent#228, 5) +-