[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-01-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr We still do not have a bandwidth to work on this issue. Could you open a JIRA and ask the community for helping this? We need a design discussion before starting the work. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-01-23 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 Execute me ,has the concept of default value been introduce to schema in master branch? @gatorsmile thank you. --- - To

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-12-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr Any progress on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80610/ Test FAILed. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80610/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80610/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-13 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 ok, I will solve the problems left first, and hold this PR @gatorsmile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr We need to introduce the concept of `default value` to our schema at first. Could you hold this PR until we finish that? Thanks! --- If your project is set up for it, you can reply to

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80538/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80538/ Test FAILed. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80538/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80515/ Test FAILed. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80515/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80515/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80484/ Test FAILed. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80484/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80484/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-09 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 You mean we can provide the different type of values with different default values? like int with 0 ,and string with "" ?Or we set the default values when define the table? @gatorsmile @maropu

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-09 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 In the most cases of `SELECT` statements, `default_value` is `NULL` by default. So, I firstly thought non-specified columns were filled with `NULL`. Anyway, we still have any chance to implement

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 This might not be applicable to Spark SQL, because we do not have a concept of DEFAULT VALUE. ``` column_definition: data_type [NOT NULL | NULL] [DEFAULT default_value] ```

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-09 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 You can see this picture,my table has three columns,and I insert only two columns, then the last column is null. @maropu @gatorsmile

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 The target of this pr is support to insert into specified columns, all columns is no need , like insert into t(a, c) values (1, 0.8) . --- If your project is set up for it, you can

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 I think this pr should be fixed in that way, maybe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 I'm still not looking into this pr though, IMHO it would be good for users to select parts of columns like other databases; ``` postgres=# create table t(a int, b text, c float8, d int);

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 I see. This PR still requires users to provide all the columns, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread lvdongr
Github user lvdongr commented on the issue: https://github.com/apache/spark/pull/18756 Thank you for review, I will finish the tests as soon as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 I think this ticket just targets to support a new syntax in `INSERT` like; ``` scala> sql("create table b2(a int, b double, c string)") scala> sql("insert into b2 values (1, 3.8, 'a')")

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 We do not have default values, right? I still do not understand the issue we try to address. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr Could you first add tests and pass all these tests in jenkins? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 @gatorsmile Thanks for the trigger! Yea, I'll check first, then I'll ping you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80425/ Test FAILed. ---

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80425/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr @maropu After a quick look, I found the PR is still far from what we can merge. @maropu Could you help @lvdongr address all the issues you can find? --- If your project is

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18756 **[Test build #80425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80425/testReport)** for PR 18756 at commit

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18756 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-08-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18756 @lvdongr Could you add tests? @gatorsmile Could you trigger jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18756: [SPARK-21548][SQL] "Support insert into serial columns o...

2017-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18756 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this