Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18780
+1 to what Michael said. List seems fine to me (YARN-related issues).
You have a typo in the PR title though.
---
If your project is set up for it, you can reply to this email and have your
Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/18780
I'm in favor of fairly aggressive closing of inactive pull requests. The
cost of reopening them is small, and the benefits of having a clear view of
what is in progress are large. I think as long
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
Sure, I added those and took out 18475.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18780
@HyukjinKwon I would add:
https://github.com/apache/spark/pull/18308
https://github.com/apache/spark/pull/18599
https://github.com/apache/spark/pull/18619
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18780
@gatorsmile @tdas to rehash the logic here:
- JIRAs track 'what' needs to happen, and PRs track a 'how' it could be
fixed. Closing a PR shouldn't necessarily mean an important issue is
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
Sure, I guess these should be:
A: Closing stale PRs, which is inactive to Jenkins test failures and review
comments more than a month with a one-weak comment to check if it is really
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18780
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18780
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80068/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18780
**[Test build #80068 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80068/testReport)**
for PR 18780 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18780
If you are asking for their opinions it'd be easier if you ask more
explicitly (A vs B) in one comment, rather than asking them to go through and
read the entire thread ...
---
If your project is
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
cc @mateiz and @marmbrus, do you mind if I ask your opinion on this? I want
to be sure on this and see if this can be justified in general because I have
made such PRs periodically. I will stop
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
Sure, let me try soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18780
@HyukjinKwon , can you please also add the closed PR title `closes #xxx
`, that would be easier for us to identify, otherwise we need to click
on by one, thanks!
---
If your project is
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
I guess It should be good to identify important and good PRs but I am sure
most of them were inactive to review comments or Jenkins failures more than a
month and I left a comment to check if
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
I will go over the SQL-related PRs in the next few days to identify which
PRs should not be closed. We should find somebody else to take them over.
---
If your project is set up for it, you can
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
But wouldn't we still be able to look though the PRs and make the list even
after being closed here? I think I am lost about why we should leave them open.
---
If your project is set up for
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
First, we need to identify a list of PRs that need to be taken over. For
example, in SQL PRs, https://github.com/apache/spark/pull/18515 should be
fixed, even if the original PR creator might
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
@gatorsmile, Sure, I will take them out if any ML committer suggests. cc
@jkbradley, @yanboliang and @mengxr who I know. Will also take a look and check
them as far as I can once more.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
BTW, I suggest to let the committers who knew the component very well to
give the suggestion to close the PRs. For example, I will not suggest to close
any ML PR.
---
If your project is set up
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
The number of JIRAs is too many. To be honest, I do not have a bandwidth to
go over all the in-progress JIRAs. I suggest to review the inactive PRs one
more time to ensure we do not miss any
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
Is the point to leave them open to make reviewers read? I think we already
had few discussion about this. The (I think) last resort, automatic closing,
was already suggested before - @rxin.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
If the PRs are closed, we might not read them any more. Thus, my suggestion
is be careful when you want to close the PRs.
---
If your project is set up for it, you can reply to this email and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
@gatorsmile, I think we still could find others even after being closed if
the point is to prevent forgetting. This list remains and there are many
in-progress JIRAs we could find someone to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18780
Before closing these PRs, we need to figure out whether they should be
taken over by someone else. If we simply close them, we might forget to fix the
related issues.
---
If your project is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18780
**[Test build #80068 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80068/testReport)**
for PR 18780 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18780
cc @srowen, @jiangxb1987, @gatorsmile, @ueshin, @jerryshao, @vanzin,
@cloud-fan and @MLnick who I believe are interested in this and could double
check this list.
---
If your project is set
26 matches
Mail list logo
