[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18786 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-17 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18786 closing and reopening to trigger AppVeyor test that timed out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80687/ Test PASSed. ---

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80687/testReport)** for PR 18786 at commit

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80687/testReport)** for PR 18786 at commit

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-09 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18786 I'm pushing for it to stay as is because it's the more logical layout of the data: min=0%, 25%, 50%, 75%, max=100%. It's also more consistent with summary of native R dataframes (and for Python the

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-08 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18786 I don't think it's a big deal either way, which is why I suggest to change the order in Scala since it is new in Scala in this release, whereas it has been in R for a few releases (or since the

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-08 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18786 I suspect it is ok for R ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-08 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18786 @rxin Any thoughts on whether it's ok to change the output of `summary` in R in a non "additive" way? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18786 Is it too late to change the Scala side output format? I suspect it doesn't matter too much on Scala/Python which order they are in and preserving the existing order in R could be helpful.

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18786 I see. I recall the method name discussion; though changing API and/or output format is something we generally want to avoid. Something like this has been called out in past releases as we

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-02 Thread aray
Github user aray commented on the issue: https://github.com/apache/spark/pull/18786 No the changes to `summary` are not additive, it inserts 25%, 50%, and 75% percentiles before max (the last row). People that want the previous behavior can use `describe`. Or if they are trying to

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18786 @HyukjinKwon I'm not sure how - in AppVeyor we are building everything from scratch... it does take time --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-01 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18786 @aray, it looks the tests with AppVeyor failed due to time limit, 1.5 hours. Would you mind closing and reopening this one to retrigger the test? @felixcheung, It sounds now we are

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80120/ Test PASSed. ---

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80120/testReport)** for PR 18786 at commit

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80120/testReport)** for PR 18786 at commit

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80091/ Test PASSed. ---

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80091/testReport)** for PR 18786 at commit

[GitHub] spark issue #18786: [SPARK-21584][SQL][SparkR] Update R method for summary t...

2017-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18786 **[Test build #80091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80091/testReport)** for PR 18786 at commit