Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80464/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80464 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80464/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80464 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80464/testReport)**
for PR 18820 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80459/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80459/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80459/testReport)**
for PR 18820 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
Yea, looks much safer. LGTM too except the comments above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18820
Please add the suggested tests then LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
LGTM except a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80382/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80382/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80382/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80379 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80379/testReport)**
for PR 18820 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80379/
Test FAILed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
Thanks! Will review it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
Hi @HyukjinKwon @gatorsmile @viirya I addressed your comments, added more
test coverage and provided more info in PR description.
One thing that is not clear to user is that they can still
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80379 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80379/testReport)**
for PR 18820 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
cc @ueshin Could you also take a look the code changes in the Python side?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
Could you also add a test case to cover the end-to-end use case the JIRA
mentioned? Also put it in the PR description, which will be part of the PR
commit. Thanks!
---
If your project is set
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18820
@bravo-zhang Could you update the PR description to explain what this PR is
trying to achieve? So far, it is not clear enough to explain what you did in
this PR. Thanks!
---
If your project is
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
Other than few comments above, LGTM. Any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80308/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80308/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80308/testReport)**
for PR 18820 at commit
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
@HyukjinKwon Thanks for review. Updated to address your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80252/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80252/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80252/testReport)**
for PR 18820 at commit
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
Hey @nchammas I don't have strong opinion on this and changed back to what
it was.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nchammas commented on the issue:
https://github.com/apache/spark/pull/18820
> I don't think we should allow user to change field nullability while
doing replace.
Why not? As long as we correctly update the schema from non-nullable to
nullable, it seems OK to me.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80229/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80229 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80229/testReport)**
for PR 18820 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18820
**[Test build #80229 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80229/testReport)**
for PR 18820 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nchammas commented on the issue:
https://github.com/apache/spark/pull/18820
Jenkins test this please.
(Let's see if I still have the magic power.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
Hi @nchammas, while you are here, could you trigger the Jenkins build?
Looks I still have some problems with triggering it.
---
If your project is set up for it, you can reply to this email
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
What if the field is not nullable? I did a test:
```
val rows = spark.sparkContext.parallelize(Seq(
Row("Bravo", 28, 183.5),
Row("Jessie", 18, 165.8)))
val
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
Hey @nchammas I made the logic much simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18820
okay to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user bravo-zhang commented on the issue:
https://github.com/apache/spark/pull/18820
This PR reopens https://github.com/apache/spark/pull/16225
Please take a look @gatorsmile @holdenk @HyukjinKwon Thanks!
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18820
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
51 matches
Mail list logo
