[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-28 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18826 Thanks for the improvement :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-28 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/18826 LGTM merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-22 Thread bravo-zhang
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/18826 @holdenk @HyukjinKwon I updated `__repr__` by calling `toString`. I also added class name `LogisticRegressionModel: ` to `toString`. Otherwise `uid` alone is a bit confusing. ---

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92240/ Test PASSed. ---

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #92240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92240/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #92240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92240/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92157/ Test PASSed. ---

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #92157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92157/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #92157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92157/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18826 I think you cc'ed right ones .. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18826 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-18 Thread bravo-zhang
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/18826 @HyukjinKwon Can you recommend someone to take a look at this PR or maybe you can take a look? --- - To unsubscribe,

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91531/ Test PASSed. ---

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18826 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #91531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91531/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18826 **[Test build #91531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91531/testReport)** for PR 18826 at commit

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18826 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18826: [SPARK-14712][ML] LogisticRegressionModel.toString shoul...

2018-06-07 Thread bravo-zhang
Github user bravo-zhang commented on the issue: https://github.com/apache/spark/pull/18826 @HyukjinKwon It's ready to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,