[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-04 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18829 To determine which metric is important and should be added to the UI is out of scope here, I agree we should stop working on this issue. --- If your project is set up for it, you can reply to

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18829 I also don't see value in exposing these machine-readable endpoints in a user interface? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18829 I understand what you mean. These metricsURLs do not need to be displayed in the WEB UI. Important metrics can be used as a header for the WEB UI, such as 'aliveWorkers' --- If your

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/18829 I'm not personally saying these metrics need to be in the Web UI, I'm just saying that if you think they're important enough to surface this way then they should be important enough to you to

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18829 Your comments I accepted, thank you. If you really make these important metrics to WEB UI, the workload is not small. I will try to do that. --- If your project is set up for it, you

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/18829 I think if we really want these metrics in the UI we should look at adding them to the UI in some way rather as a link to a json dump. I am not a fan of json dumps as part of a UI in general, I

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18829 Hbase WEB UI has metrics, Spark WEB UI should also have the function. This is just my opinion.

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18829 I tend to agree with @ajbozarth , since we already have the APIs to access metrics dump with json format, this looks like not so necessary. Also directly displaying such kind of json dump on the

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18829 Json Metrics information is very full, a lot of information UI is currently unable to show, but this information for the application developers is also very important. I

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/18829 I don't understand the point of this PR, why do we want links to json dumps of information available on the UI? If a user wanted those dumps they can already access them via the API, I don't

[GitHub] spark issue #18829: [SPARK-21620][WEB-UI][CORE]Add metrics url in spark web ...

2017-08-03 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18829 @srowen @ajbozarth Help review the code,Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not